GoogleChrome / GoogleChrome/lighthouse

i18n: use locale for all numeric formatting in the report

Open
#10,786 12 comments 0 reactions 1 assignee Claimed by @connorjclark View on GitHub
i18n P1.5
Dominant language
JavaScript
Stars
30.8k
Forks
9.8k
Avg merge
1d 14h
Merged PRs (30d)
20

Description

The titles for the new diagnostics (although I predict any ICU plural we use with an explicit "1") are not rendered properly with non-standard numeric representations.
![image](https://user-images.githubusercontent.com/6392995/81980798-1e339300-95e4-11ea-97e9-9a02ca90294d.png)

This is because the ICU decleration for the "1" case is explicitly an `en` "1".
```javascript
displayValue: `{nodeCount, plural,
=0 {No elements found}
=1 {1 element found} // this uses the literal "1"
other {# elements found} // this uses the number, like the character "١"
}`,
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.