GoogleChrome / GoogleChrome/lighthouse

[web.dev] Incorrectly flagging cross-origin links as not containing noopener/noreferrer (Best Practices)

Open
#10,417 5 comments 3 reactions 1 assignee Claimed by @connorjclark View on GitHub
bug needs-investigation P1.5 PSI/LR
Dominant language
JavaScript
Stars
30.8k
Forks
9.8k
Avg merge
1d 20h
Merged PRs (30d)
19

Description

#### Provide the steps to reproduce
1. Run LH on https://willstocks.co.uk
2. View the results
3. Scroll to Best Practices

#### What is the current behavior?

Under "Best Practices", I'm seeing the following:
![image](https://user-images.githubusercontent.com/43744514/75789593-d67dc900-5d61-11ea-9ea7-4b9855f715d9.png)

However, when I check my markup, I'm seeing that `noopener` and `noreferrer` are infact defined alongside `bookmark`.

The markup that is being complained about is:
```html




Manipulating the DOM with PHP's DOMDocument()



PHP DOM Manipulation (snippet)




```
#### What is the expected behavior?

If the link to a cross-origin domain contains the recommended `rel` attributes, surely this shouldn't flag up as an issue?

#### Environment Information
* Affected Channels: https://web.dev/measure
* Lighthouse version: 5.6.0
* Chrome version: 80.0.3987.122
* Node.js version:
* Operating System: W10 Enterprise 1909

**Related issues**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.