GoogleChrome / GoogleChrome/lighthouse

new audit: have a valid favicon.ico

Open
#10,402 3 comments 0 reactions 0 assignees View on GitHub
feature new_audit P2
Dominant language
JavaScript
Stars
30.8k
Forks
9.8k
Avg merge
1d 14h
Merged PRs (30d)
20

Description

#### Provide the steps to reproduce
1. Run LH on https://condescending-haibt-2d0d42.netlify.com/bug.html

#### What is the current behavior?
| URL | Description |
|------------------------------------------------------|-----------------------------------------------------------------------|
| /favicon.ico(condescending-haibt-2d0d42.netlify.com) | Failed to load resource: the server responded with a status of 404 () |

![current behavior](https://user-images.githubusercontent.com/1120926/75489159-0586ea00-59b2-11ea-94fc-05e096046535.png)

#### What is the expected behavior?
Favicon shouldn't be a violation

#### Environment Information
* Affected Channels: CLI, Node
* Lighthouse version: 5.6.0
* Chrome version: 80.0.3987.100
* Node.js version: 12.14.1
* Operating System: Windows

**Related issues**
https://github.com/GoogleChrome/lighthouse/issues/10381
https://github.com/GoogleChrome/lighthouse/pull/10190

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the Lighthouse CLI result for https://condescending-haibt-2d0d42.netlify.com/bug.html and reviewing related issue #10381 and pull request #10190. Define the audit's expected behavior from the missing /favicon.ico report; done means the audit handles this case consistently without treating the favicon problem as an unresolved violation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli, testing-qa, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.