GoogleChrome / GoogleChrome/lighthouse-stack-packs
Drupal `uses-responsize-images` unclear
- Dominant language
- JavaScript
- Stars
- 218
- Forks
- 76
- PR merge metrics
- No merged PRs in 30d
Description
The second half of the string https://github.com/GoogleChrome/lighthouse-stack-packs/blob/master/packs/drupal.js#L28 is unclear.
> Use the Responsive Image Styles when rendering image fields through view modes, views, or images uploaded through the WYSIWYG editor.',
Are there three ways of rendering an `image field`? (through a `view mode`, a `view`, or via upload from the WYSIWYG editor) Or is the WYSIWYG editor different and is uploading images directly instead of through fields?
This needs to be re-written by someone who knows what all these Drupal terms mean 😄
Contributor guide
Research direction
Start with packs/drupal.js at line 28 and review the wording of the uses-responsize-images string. Clarify the Drupal meanings of view modes, views, image fields, and WYSIWYG uploads before rewriting the sentence. Done means the string accurately distinguishes the relevant image-rendering paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- drupal, javascript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100