GodotModding / GodotModding/godot-mod-loader

ModLoaderUserProfile - Reset the current user profile if the save failed

Open
#295 0 comments 0 reactions 1 assignee Claimed by @KANAjetzt View on GitHub
enhancement
Dominant language
GDScript
Stars
675
Forks
54
Avg merge
2m
Merged PRs (30d)
2

Description

> should we reset the current user profile if the save failed?

_Originally posted by @Qubus0 in https://github.com/GodotModding/godot-mod-loader/pull/293#discussion_r1236583778_

Additionally on Discord:
> Ste — Today at 09:11
resetting to the one that was previously set
this might be a thing we have to pull through multiple places where we save stuff
and the save error messages also should be properly logged, otherwise they can't be resolved - if that isn't the case yet. it might tbe that it is logged twice, once in the save and once as general "can't be saved" in the method that tries to save
i'm thinking that this "aplying but not saving" issue might have led to the report by rene.. the mod was toggled inactive, but the save failed. then the game was restarted and the profile went back to the pre-save state, so it looked like the mod disabled itself

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.