GodotModding / GodotModding/godot-mod-loader

Dependency Versions

Open
#129 0 comments 0 reactions 0 assignees View on GitHub
3.x 4.x validation
Dominant language
GDScript
Stars
675
Forks
54
Avg merge
2m
Merged PRs (30d)
2

Description

### Problem

As discussed on Discord today ([here](https://discord.com/channels/1028191864966361178/1042776216983314443/1078682025575338025)), if we want parity between the Thunderstore manifest.json and our current one, then we need to ensure that dependencies have version strings, eg:

```
"dependencies": [
"Darkly77-ContentLoader-5.0.0"
]
```

But we also need to support dependencies without them, because Brotato's workshop support has launched without this requirement. This means that this also needs to be valid (like it currently is):

```
"dependencies": [
"Darkly77-ContentLoader"
]
```

### Suggestion

- Add a new mod ID validation check to ensure that a version string is present.
- If they are missing, trigger a fatal error in the editor (to notify the mod creator).
- However, outside of the editor, allow normal execution of the code (ie. proceed to the next step of validation, below).
- Keep the legacy validation, which doesn't check for the version string.
- An error here should prevent the mod from loading, whether you'r in the editor or not (just like it currently does).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.