Glavin001 / Glavin001/tslint-clean-code

Use Array.prototype.find() instead of .filter()[0]

Open
#56 1 comment 0 reactions 0 assignees View on GitHub
good first issue help wanted
Dominant language
TypeScript
Stars
175
Forks
15
PR merge metrics
No merged PRs in 30d

Description

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find

```javascript
const items = [
{ id: 123 },
{ id: 456 }
// ...
];
const selectedId = 456;
const selectedItem = items.filter(item => item.id === selectedIds)[0];
```

Should be:

```javascript
// ...
const selectedItem = items.find(item => item.id === selectedIds);
```

Diff:

```diff
- const selectedItem = items.filter((item) => item.id === selectedIds)[0];
+ const selectedItem = items.find((item) => item.id === selectedIds);
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.