Gjum / Gjum/SnitchMod

Distinguish between soon-to-cull and soon-to-dormant snitches

Open
#50 1 comment 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Java
Stars
6
Forks
13
PR merge metrics
No merged PRs in 30d

Description

The problem is, the same color, ORANGE, is used for a snitch that will merely go dormant soon and a snitch that will soon cull entirely.

[Currently](https://github.com/Gjum/SnitchMod/blob/master/common/src/main/java/gjum/minecraft/civ/snitchmod/common/Renderer.java#L125), the snitch fields are colored as follows:

- Culled: RED
- Dormant: ORANGE
- Will be dormant soon (within 3 days) : ORANGE
- Will be dormant soon-ish (within 7 days) : YELLOW
- Healthy: GREEN

We probably need a new stage, culling soon(-ish?), to be shown 3/7 days before the snitch culls. Probably 7. At the same time, we should remove the intermediate dormant soon stage, for consistency:

- Culled: RED
- Will be culled soon-ish (within 7 days) : ORANGE
- Dormant: YELLOW
- Will be dormant soon-ish (within 7 days) : ??? (PURPLE? BLUE?)
- Healthy: GREEN

This way we have a single pre-dormant and a single pre-cull stage, with each being active 7 days prior. I think that should be consistent and intuitive. Just need to find a new color for the dormant soon-ish stage. Logically it'd be a color between green and yellow.

Alternatively, we could find a new, fitting color for any of the other stages.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.