Editing a block in a CR that has been submitted for review deletes the entire block
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 29k
- Forks
- 4k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 71
Description
Bug description
In the web editor, editing a block in a CR that has been submitted for review deletes the entire block.
How to reproduce
- Create a CR
- Edit a block and submit it for review
- Once reviewed, edit a block in that page (have not tested editing other pages)
- Refresh the page, open the CR in another tab, have another user anywhere load the CR
- The entire edited block (not just the changes from step 2) is gone. It does not appear in the history.
Additional context
This has happened to me three times in three different pages. My coworkers have reported the same thing. Both images and text blocks have disappeared. Blocks disappear whether they have a comment (from review) on them or not.
It should go without saying that this makes GitBook unusable for collaborative work.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the web editor workflow in the issue: create a CR, submit a block for review, edit it after review, refresh, and load the CR elsewhere. Trace how reviewed block edits are persisted and shown in history; done means edited text and image blocks remain intact for other users and in the history.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100