GeoDaCenter / GeoDaCenter/jsgeoda

Fix missing `</script>` closing tag in the doc

Open
#4 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
26
Forks
4
PR merge metrics
No merged PRs in 30d

Description

It seems it's at gitbook.io level doc not in the repo.

In https://xunli.gitbook.io/jsgeoda/user-guide/hello-jsgeoda#pure-js, you provides the following

```

import jsgeoda from 'https://cdn.skypack.dev/-/jsgeoda@v0.2.2-Lc34LnJ0L2k7CJpnhQri/dist=es2020,mode=imports/optimized/jsgeoda.js';
jsgeoda.New().then((geoda)=> {
console.log('Hello jsgeoda', geoda.version);
});
</body>
</html>
```

whereas it should be

```html
<html>
<head>
</head>
<body>
<script type="module">
import jsgeoda from 'https://cdn.skypack.dev/-/jsgeoda@v0.2.2-Lc34LnJ0L2k7CJpnhQri/dist=es2020,mode=imports/optimized/jsgeoda.js';
jsgeoda.New().then((geoda)=> {
console.log('Hello jsgeoda', geoda.version);
});

```

Been aware of the issue as Chrome was working with this unclosed tag whereas Firefox was not auto-fixing the unbalance tag and failing

Contributor guide

No contributing guide indexed for this repository

Research direction

Open the GitBook URL and navigate to the Pure JS section of the user guide. Compare the HTML example with the corrected snippet in the issue, then update the external documentation if you have access. Done means the module script has a closing tag and the example renders in Firefox as well as Chrome.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.