Genymobile / Genymobile/scrcpy
[Suggestion] Put user-friendly name of device in window name
- Dominant language
- C
- Stars
- 150k
- Forks
- 13.7k
- Avg merge
- 4d 13h
- Merged PRs (30d)
- 2
Description
For testing purpose
`shell getprop ro.product.model` returns models as **SM-G960F** (Galaxy S9) for samsung devices.
Things like Motorola return readable user-friendly names, i.e. **Motorola E4 Plus**.
But sometimes they don't: **XT1635-02** (Motorola Z Play).
I remember all models which i work with by heart. But eye catches easily when you have window named **Samsung Galaxy S6 Edge+ (SM-G928F)**
`shell settings get secure bluetooth_name` returns almost on every device (Galaxy S4 mini is still GT-9195. But it's initially called like that so doesn't matter) its name if it wasn't changed by user.
**How reasonable is getting the name from settings?**
It's kind of slow. Or maybe i'm doing that wrong. Because if you make loop which gets info about all connected devices
```
#!/bin/bash
for serial in $(adb devices | awk 'NR>1{print $1}');
do
echo $(adb -s $serial shell settings get secure bluetooth_name | sed "s/\\r//g")
done
```
it would work significantly slower than
```
#!/bin/bash
for serial in $(adb devices | awk 'NR>1{print $1}');
do
echo $(adb -s $serial shell getprop ro.product.model | sed "s/\\r//g")
done
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Use the reported adb commands as the behavioral reference: compare the existing model-based window name with the proposed user-friendly device name from secure bluetooth_name. The issue names no source files or tests, so first locate the window-title handling and device-information retrieval, then verify the result across devices where the model is not human-readable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, c
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100