Genymobile / Genymobile/scrcpy

Minimize Brightness on Non-AMOLED Devices When Display is Turned Off

Open
#4,597 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
150k
Forks
13.7k
Avg merge
4d 13h
Merged PRs (30d)
2

Description

I hope this message finds you well. I am a user who greatly appreciates the functionality and convenience that scrcpy provides. I've noticed a small issue when using scrcpy with non-AMOLED devices and the screen is turned off using the -S parameter.

The problem arises when the screen displays a black color, causing non-AMOLED screens to show a bluish tint rather than turning the pixels off completely. To address this, I would like to propose a feature that minimizes the brightness to the lowest possible level when the screen is turned off.

Please note that on some devices, setting the brightness to 0 through adb shell may not be supported. Therefore, I suggest setting the brightness to 1 as an alternative to achieve the desired effect. This would not only conserve energy but also contribute to the longevity of non-AMOLED screens.

I believe implementing this feature, with the suggested adjustment, would enhance the user experience, especially for those with non-AMOLED devices.

Thank you for your time and consideration.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the existing -S screen-off path and inspect the Android device-control entry points where an adb shell brightness command could be applied. Verify the behavior on non-AMOLED devices, including devices where brightness 0 is unsupported; done means brightness is minimized to 1 when the display is turned off.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, c
Domain
mobile-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.