GenieFramework / GenieFramework/StippleDemos

Update Tree Example

Open
#31 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
50
Forks
29
PR merge metrics
No merged PRs in 30d

Description

The Tree demo is broken. I tried following the deprication messages but I'm still running into problems.

╭─mcamp on Butler in ~/code/StippleDemos/BasicExamples/Tree on master🔥
╰─🚧 julia Tree.jl        
┌ Warning: @reactive! is deprecated, please replace use `@vars` instead.
│ 
│ In case of errors, please replace `@reactive!` by `@old_reactive!` and open an issue at
│ https://github.com/GenieFramework/Stipple.jl.
│ 
│ If you use `@old_reactive!`, make sure to call `accessmode_from_pattern!()`, because the internals for
│ accessmode have changed, e.g.
│ ```
│ model = init(MyDashboard) |> accessmode_from_pattern! |> handlers |> ui |> html
│ ```
└ @ Main ~/.config/julia/packages/Stipple/qnyBY/src/stipple/reactivity.jl:430
ERROR: LoadError: UndefVarError: register_mixin not defined
Stacktrace:
 [1] top-level scope
   @ ~/code/StippleDemos/BasicExamples/Tree/Tree.jl:39
in expression starting at /home/mcamp/code/StippleDemos/BasicExamples/Tree/Tree.jl:39
╭─mcamp on Butler in ~/code/StippleDemos/BasicExamples/Tree on master🔥
╰─🚧 vim Tree.jl        
╭─mcamp on Butler in ~/code/StippleDemos/BasicExamples/Tree on master🔥
╰─🚧 vim Tree.jl
╭─mcamp on Butler in ~/code/StippleDemos/BasicExamples/Tree on master🔥
╰─🚧 julia Tree.jl
ERROR: LoadError: type Bool has no field args
Stacktrace:
 [1] getproperty(x::Bool, f::Symbol)
   @ Base ./Base.jl:38
 [2] var"@var_storage"(__source__::LineNumberNode, __module__::Module, expr::Any, new_inputmode::Any)
   @ Stipple ~/.config/julia/packages/Stipple/qnyBY/src/stipple/reactivity.jl:258
 [3] var"@var_storage"(__source__::LineNumberNode, __module__::Module, expr::Any)
   @ Stipple ~/.config/julia/packages/Stipple/qnyBY/src/stipple/reactivity.jl:247
 [4] eval(m::Module, e::Any)
   @ Core ./boot.jl:368
 [5] var"@vars"(__source__::LineNumberNode, __module__::Module, expr::Any)
   @ Stipple.ReactiveTools ~/.config/julia/packages/Stipple/qnyBY/src/ReactiveTools.jl:151
in expression starting at /home/mcamp/.config/julia/packages/Stipple/qnyBY/src/ReactiveTools.jl:151
in expression starting at /home/mcamp/code/StippleDemos/BasicExamples/Tree/Tree.jl:27
in expression starting at /home/mcamp/code/StippleDemos/BasicExamples/Tree/Tree.jl:27

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with BasicExamples/Tree/Tree.jl, especially the reported failures at lines 27 and 39, and run the demo to reproduce the errors. Compare the deprecated @reactive! guidance and the @vars and accessmode_from_pattern! examples in the report. Done means the Tree demo runs successfully without the reported UndefVarError and Bool field error.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.