GenericMappingTools / GenericMappingTools/gmt
Let pshistogram handle both Cartesian and polar histograms
- Dominant language
- C
- Stars
- 979
- Forks
- 414
- Avg merge
- 17h 26m
- Merged PRs (30d)
- 54
Description
**Description of the desired feature**
The **psrose** module is very old (2.4.1) and has a checkered history:
1. It started off life not using **-J** but had a **-S**_radius_ option.
2. The **-R** option is backwards [**-R**_r0/r1/theta0/theta1_] relative to other azimuthal plots.
3. Because not implemented as a projection we cannot use the **-B** machinery so any annotation problem requires fixes to the module itself.
4. In GMT 5 we added **-JX**_diameter_ (as if this is a square Cartesian projection) because it would give the appearance of using **-J**.
5. Elsewhere in GMT, we use have the polar cylindrical projection **-JP** with proper **-B** support, and here **-R** is properly given as **-R**_theta0/theta1/r0/r1_.
It is too late to fix the way **psrose** works. I propose this solution to address all the wrong things in **psrose** as well as enable future features:
1. Add the polar histogram to **pshistogram** via **-JP**. Then **-JX** sets the Cartesian histogram and **-JP** does the polar. Both projections have proper **-R** and **-B** support.
2. Deprecate **psrose** so it is no longer discussed but it will remain available under the hood for backwards usage.
Accepting comments from @GenericMappingTools/core.
Contributor guide
Assessment
This issue has not been assessed yet.