GeekyAnts / GeekyAnts/NativeBase
Make `react-dom` optional peerDependency
Open
PR Added
v3
- Dominant language
- TypeScript
- Stars
- 20.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
### Description
I would suggest to make `react-dom` an optional `peerDependency`, since pure `react-native` projects don't use `react-dom` at all.
### Problem Statement
The current forced `peerDependency` causes projects with no `react-dom` in their `dependencies` to cause an error with recent `npm` versions.
### Proposed Solution or API
Add a [peerDependencyMeta](https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependenciesmeta) attribute inside `package.json` and declare `react-dom` as optional:
```json
...
"peerDependencyMeta": {
"react-dom": {
"optional": true
}
},
...
Contributor guide
Assessment
This issue has not been assessed yet.