GeekyAnts / GeekyAnts/NativeBase

Theme components variants not override custom default props in same component

Open
#5,450 1 comment 0 reactions 0 assignees View on GitHub
bug triage v3
Dominant language
TypeScript
Stars
20.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

### Description

If same component has custom default props and custom variants, its variants doesn't override defualt props, and they must be more "important"

### CodeSandbox/Snack link

https://codesandbox.io/s/gifted-roentgen-7p0ttv

### Steps to reproduce

1. Create having in custom theme , new variants and custom defaultProps.

### NativeBase Version

^3.4.15

### Platform

- [X] Android
- [ ] CRA
- [X] Expo
- [X] iOS
- [ ] Next

### Other Platform

Storybook

### Additional Information

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the linked CodeSandbox and reproduce the themed TextArea using custom defaultProps and variants on NativeBase 3.4.15. Trace how the component resolves those theme settings on Android, iOS, and Expo, then verify that the variant values take precedence over the custom defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
frontend, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.