GeekyAnts / GeekyAnts/NativeBase

Responsive Icon size prop broken in 3.4.17.

Open
#5,449 4 comments 0 reactions 0 assignees View on GitHub
bug triage v3
Dominant language
TypeScript
Stars
20.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Something has changed between 3.4.11 to 3.4.17 that broke responsive `Icon size = {}`.
I noticed two separate things.
1 - The theme.components.Icon customizations in my theme aren't being merged.
2 - Directly adding `size={{ base: 'lg', sm: 'lg', md: 'xl', lg: '2xl', xl: '3xl' }}` to an Icon does nothing.

Maybe this?
https://github.com/GeekyAnts/NativeBase/pull/5229

[EDIT]
Could go up to 3.4.13 before things broke. Looks like it's probably in 3.4.14/5

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.