GameServerManagers / GameServerManagers/LinuxGSM
Double quotes parms
- Dominant language
- Shell
- Stars
- 4.9k
- Forks
- 864
- PR merge metrics
- No merged PRs in 30d
Description
## User Story
As a developer, I want to change parms from using double quotes to single quotes to help prevent issues with using double quotes within the variable.
for example
```
parms="${defaultmap}?Scenario=${defaultscenario}?MaxPlayers=${maxplayers}?Port=${port}?QueryPort=${queryport} -hostname="My Server" -log"
```
This causes a hostname to be displayed on the server browser as `My` instead of `My Server`
To fix this we can escape the double quotes like so `\"My Server\"`. However, this does not look very clean and could confuse people.
Instead of changing parms from `parms=""` to `parms=''` will prevent the need for the `\` escape character and allow double quotes
Contributor guide
Assessment
This issue has not been assessed yet.