Gallopsled / Gallopsled/pwntools

Sphinx 9 incompatibility

Open
#2,711 0 comments 0 reactions 0 assignees View on GitHub
backport-required bug
Dominant language
Python
Stars
13.7k
Forks
1.9k
Avg merge
6d 23h
Merged PRs (30d)
3

Description

Running our doctests using Sphinx 9+, the `context.clear()` calls in hidden doctest sections aren't executed causing the following tests to fail since the assembler still uses `arm` instead of `i386`.

https://github.com/Gallopsled/pwntools/blob/f55f440c07453e7a2441bb71d155b77f419b2bd2/docs/source/intro.rst?plain=1#L146-L149

We should investigate the problems before updating [our monkey-patches in conf.py](https://github.com/Gallopsled/pwntools/blob/f55f440c07453e7a2441bb71d155b77f419b2bd2/docs/source/conf.py#L405) for Sphinx 9 support (or consider requesting proper hooks upstream).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.