Gallopsled / Gallopsled/pwntools
Use ssh with proxy_sock has some problem
Open
bug
good first issue
- Dominant language
- Python
- Stars
- 13.7k
- Forks
- 1.9k
- Avg merge
- 6d 23h
- Merged PRs (30d)
- 3
Description
When I use ssh with proxy_sock and proxy_sock is `unix domain socket`, getsockname will return '', and sockname[0] will cause an Exception
https://github.com/Gallopsled/pwntools/blob/7e03bfd5a659afeaa165094b39e0ecec90c547c4/pwnlib/tubes/ssh.py#L459-L461
Contributor guide
Research direction
Start by reading the proxy socket handling around pwnlib/tubes/ssh.py lines 459-461, focusing on the behavior of getsockname for a Unix domain socket. Reproduce the exception with a Unix socket, then ensure this case is handled without indexing an empty result and verify the SSH proxy behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100