GalaChain / GalaChain/sdk

Add validation to `@ChainKey` to prevent utf 0 in keys

Open
#700 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
138
Forks
44
Avg merge
1d 16h
Merged PRs (30d)
22

Description

suggested changes:

```diff
export interface ChainKeyMetadata extends ChainKeyConfig {
key: string | symbol;
+ allowUtf0?: boolean
}

export function ChainKey(chainKeyConfig: ChainKeyConfig): PropertyDecorator {
return (target, key) => {
const fields: ChainKeyMetadata[] = Reflect.getOwnMetadata("galachain:chainkey", target) || [];

const existingField = fields.find((field) => field.position === chainKeyConfig.position);

+ // inject somewhere a validation decotator to fail on utf0

if (existingField === undefined) {
fields.push({ key, ...chainKeyConfig });
Reflect.defineMetadata("galachain:chainkey", fields, target);
}
};
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.