GalaChain / GalaChain/sdk

Fix DER 144 signature test

Open
#305 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
138
Forks
44
Avg merge
1d 16h
Merged PRs (30d)
22

Description

The test for multiple formats has invalid input. Find the following code in `signatures.spec.ts`:

```
// der144Signature
"3045022100f6d3aefb132b74e879a937dc6a28003d6c2acee6e27291bfb24834aa2cd2a610022003a06b8f150ab71b3e19621114f98416417bea4fbc5b3b4a30b610fea9f281e1"
```

It’s actually der142 (not 144), the length is the same as the prev signature in the test. The test case needs to be fixed by providing valid DER 144-length signature.

Contributor guide

No contributing guide indexed for this repository

Research direction

Open signatures.spec.ts and locate the multiple-formats test and its der144Signature fixture. Replace the invalid DER 142-length value with a valid DER 144-length signature, then run the relevant signature test to confirm the fixture is accepted.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.