GalaChain / GalaChain/sdk

Handle Partial Success in fulfillMintAllowanceRequest

Open
#267 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
138
Forks
44
Avg merge
1d 16h
Merged PRs (30d)
22

Description

The fulfillMintAllowanceRequest function processes a batch of TokenMintAllowanceRequest entries and updates the state for each request. If an error occurs during the processing of a request, the function records the error but continues processing the remaining requests. This can lead to a situation where some requests are successfully processed and their state updates are committed to the chain, while others fail, resulting in partial success.

fulfillMintAllowance.ts#L171

Certik finding: MAG-01

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at fulfillMintAllowance.ts#L171 and trace fulfillMintAllowanceRequest's batch processing and state updates. Reproduce the behavior with a batch containing both successful and failing TokenMintAllowanceRequest entries, then verify the handling of partial success against the MAG-01 finding. Done means the function no longer leaves an unintended mix of committed successes and failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.