GalSim-developers / GalSim-developers/JAX-GalSim
figure out how to enable non-default Sensors that carry state
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 34
- Forks
- 10
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 3
Description
Right now when photons are added to sensors, it is done inside of a JITed function. Thus any internal state in the Sensor is not automatically propagated back out. We should figure out a way to do this if we ever add stateful sensors (e.g., a sensor that does brighter fatter).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. First inspect how photons are added to sensors inside the JITed function and how sensor state is represented; then determine how state from stateful sensors such as brighter-fatter could be propagated out. Done means a decided approach that supports non-default stateful sensors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100