GSG-G10 / GSG-G10/W7-ToDo

Returning un-used date

Open
#60 0 comments 0 reactions 0 assignees View on GitHub
review
Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Here you are telling the database to return everything after inserting them but why?
You are not using them in the controller at all !!

https://github.com/GSG-G10/W7-ToDo/blob/9732c79189a00e005547aec1357720691b619383/server/database/queries/add_user_query.js#L3

https://github.com/GSG-G10/W7-ToDo/blob/9732c79189a00e005547aec1357720691b619383/server/controllers/createUser.js#L7-L8

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with server/database/queries/add_user_query.js at the linked line, then inspect server/controllers/createUser.js lines 7-8 to confirm whether the returned database value is consumed. Done means the query no longer returns unused data while user creation continues to work as before; check any available user-creation test or run the relevant application flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
databases
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.