GSG-G10 / GSG-G10/W7-ToDo

Checking for user existence by not a unique value

Open
#49 0 comments 0 reactions 0 assignees View on GitHub
review
Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

So, here as a part of the login process, you are checking if the user is existed by doing a search by the username which is not a unique value and there could be multiple users with the same username and this should have been done by searching by the email which is not a unique value also in your database

https://github.com/GSG-G10/W7-ToDo/blob/9732c79189a00e005547aec1357720691b619383/server/controllers/get_auth.js#L7

https://github.com/GSG-G10/W7-ToDo/blob/9732c79189a00e005547aec1357720691b619383/server/database/config/data.sql#L5-L6

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with server/controllers/get_auth.js at the linked line, then inspect server/database/config/data.sql lines 5-6 to compare the login lookup with the available user fields and constraints. Clarify which user identifier is intended to be unique; done means the authentication lookup and database definition consistently use that identifier.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, sql
Domain
authentication, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.