GSG-G10 / GSG-G10/Trading-View---team-4
General Notes at DomFunction
- Dominant language
- CSS
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
You did a great effort on domFunction.js file. Sometimes small points to consider make huge differences.
- #### use descriptive and meaningful names to your variable
https://github.com/GSG-G10/Trading-View---team-4/blob/45d2eef6f0f10a464cc66ce2d608af27313199d3/scripts/DomFunctions.js#L70
https://github.com/GSG-G10/Trading-View---team-4/blob/45d2eef6f0f10a464cc66ce2d608af27313199d3/scripts/DomFunctions.js#L77
- #### be consistent on way declaring functions, either use function declarations or function expression
https://github.com/GSG-G10/Trading-View---team-4/blob/45d2eef6f0f10a464cc66ce2d608af27313199d3/scripts/DomFunctions.js#L3
https://github.com/GSG-G10/Trading-View---team-4/blob/45d2eef6f0f10a464cc66ce2d608af27313199d3/scripts/DomFunctions.js#L25
- #### Don't repeat yourself, instead of having those lines creating elements and add class and text content, ...etc. make a generic function to handle this stuff for you.
- #### Remove commented lines.
https://github.com/GSG-G10/Trading-View---team-4/blob/45d2eef6f0f10a464cc66ce2d608af27313199d3/scripts/DomFunctions.js#L3
- #### why there is an empty function, just remove it.
https://github.com/GSG-G10/Trading-View---team-4/blob/45d2eef6f0f10a464cc66ce2d608af27313199d3/scripts/DomFunctions.js#L86-L87
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.