GSG-G10 / GSG-G10/M7M-ToDo

General Notes

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
review
Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Here I will try to put some quick notes:
1. Where are the `README` and the deployment link?
2. You should move your project files to the root
3. You should change the document title and the description from 'index.html`.
4. You should remove unnecessary files that are installed with `create-react-app` like : `reportWebVitals.js`, `logo.svg`, `App.test.js`, and `setupTests.js`.
5. One of the project requirements was to use `React Router` and you didn't create routes.
6. This line needs to be handled in a better way using `useEffect`
```js
const [data, setData] = useState(localStorage.getItem('tasks') ? JSON.parse(localStorage.getItem('tasks')) : []);
```
7. Why this line exists in the production `console.log('zuhdi hwa al hal');`?
8. You should add a key to the map `{data.map(item => )}`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.