GSG-G10 / GSG-G10/DevMonkeys-Ecommerce

Tests

Open
#38 1 comment 1 reaction 0 assignees View on GitHub
bug review
Dominant language
JavaScript
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

You did a great job with tests and you wrote enough tests to cover all the pure logic functions you have but there's a problem encountered with the imports and the export
https://github.com/GSG-G10/DevMonkeys-Ecommerce/blob/0b47b4ec1f48ee4bd3270d6c49b4f9ce9c2a47b9/test/test.js#L1

There's some repeated functions , it should be like this and `filterByCategory` isn't exported in `logic.js`
```js
const {filterByCategory , FilterByPrice ,search,addItem , deleteItem, editItem, sumCart} = require ("../js/logic.js");
```

```js
if (typeof module !== 'undefined') {
module.exports = {
filterByCategory, addItem, search, editItem, sumCart, FilterByPrice, deleteItem
}
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.