GSA / GSA/data.gov

harvester api faceting broken for most operators

Open
#5,852 1 comment 0 reactions 0 assignees View on GitHub
API bug
Dominant language
Python
Stars
1.1k
Forks
200
Avg merge
4h 56m
Merged PRs (30d)
5

Description

seems like only `eq` works in faceting for harvester api. that's the only operator used in our [tests](https://github.com/GSA/datagov-harvester/blob/0b87fa851e653588597ae7d9ce1f9d4c23d964bc/tests/integration/app/test_routes.py#L303-L352)

i figure something like this should work? i want to capture all waf and waf-collection sources to restart them.
https://harvest.data.gov/harvest_sources/?facets=schema_type%20startswith_op%20waf

`query_filter_builder` needs to be updated to work as `self.db.query(model_class).filter(*facet_list)`

## How to reproduce
go to provided link or try any other `sqlalchemy.sql.operators`

## Expected behavior
`startswith_op` works as intended.

## Actual behavior
`error with query`

## Sketch
- add more tests with a variety of different operators

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.