GSA / GSA/data.gov

add support for `srv:SV_ServiceIdentification` as `gmd:identificationInfo`

Open
#5,321 1 comment 0 reactions 0 assignees View on GitHub
Harvest-Transform
Dominant language
Python
Stars
1.1k
Forks
200
Avg merge
4h 56m
Merged PRs (30d)
5

Description

## User Story

In order to improve ISO19115-2 reading capabilities, datagov wants to add support for processing `srv:SV_ServiceIdentification` elements as `gmd:identificationInfo` children

## Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using [BDD](https://en.wikipedia.org/wiki/Behavior-driven_development#Behavioral_specifications).]

- [ ] GIVEN an [ISO doc](https://meta.geo.census.gov/data/existing/decennial/GEO/GPMB/TIGERline/TigerWeb/Census2010_tigerRest_Urban_2017.xml) where `srv:SV_ServiceIdentification` exists as the child of `gmd:identificationInfo` \
WHEN reading of the document happens \
THEN that element will be parsed correctly \
[AND optionally another verifiable outcome]

## Background
- the AC doc failed ISO19115-2 validation which prevented it from being written to DCATUS.
- [srv namespace](https://schemas.isotc211.org/19119/srv/srv/) declares `SV_ServiceIdentification` can substitute `gmd:AbstractMD_Identification` which `gmd:MD_DataIdentification` is a type of.

## Security Considerations ([required](https://nvd.nist.gov/800-53/Rev4/control/CM-4))

[comment]: # "Our SSP says 'The Data.gov team ensures security implications are considered as part of the agile requirements refinement process by including a section in the issue template used as a basis for new work.' so please don't remove this section without care."
[Any security concerns that might be implicated in the change. "None" is OK, just be explicit here!]

## Sketch
- we might be good just updating the xpath [here](https://github.com/GSA/mdTranslator/blob/68ebf5217aac3727d59ba4b056b8e3fb83bee2ed/lib/adiwg/mdtranslator/readers/iso19115_2_datagov/modules/module_data_identification.rb#L17) with an `|` operator which includes `srv:SV_ServiceIdentification`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.