GSA / GSA/ITDB-schema

System Investment List Issues

Open
#384 6 comments 0 reactions 0 assignees View on GitHub
Resolved
Dominant language
No language data
Stars
20
Forks
30
PR merge metrics
No merged PRs in 30d

Description

I am encounting some issues in attempting to report systems data. The first two are related to delete operations, and the other is related to an odd behavior releated to ordering of the data in the XML.

The first issue relates to deleting a system. When attempting a "delete" operation, I receive the following error:

000042-SYS: SystemUniqueIdentifierCode is required.

Because SUIC is a new field, if a record is being deleted, the system may not have one, and it does not make sense to assign one.

The second issue is similar and relates to deleting a product. When attempting a "delete" operation, I receive the following errors:

◦alert 000050-SYS: vendorName is required if customDeveloped is 'No'.
◦alert 000051-SYS: Version Number is required if customDeveloped is 'No'.
◦alert 000052-SYS: Product Expected End of Life is required if customDeveloped is 'No'.
◦alert 000053-SYS: lastMajorTechRefresh is required if customDeveloped is 'No'.
◦alert 000054-SYS: anticipatedTechRefresh is required if customDeveloped is 'No'.

Again, when deleting, it does not make sense to require data that is not available and is meaningless in any event when the record is being deleted. (An alternative would be to allow vendor and version to be blank during a delete, since this was allowed last year when "N/A" was provided for the product name.)

Finally, I have noted an unusual behavior when attempting to submit multiple systems in a single XML file. In particular, If I try to submit records for two systems as follows:

1. A system uptate with products.
2. A system delete - no "products" tag is included

When I order the records 1/2 in the XML, the products for 1 are updated and the system delete for 2 is also. If system 1 has product errors, those are displayed.

However, when I order the records 2/1 in the XML, while the system delete for 2 processes, the product changes for 1 do not. I receive the message "Submission Successful for UII 009-000000000". This is true even if there are errors in the product data for system 2. Additionally, even if the data is valid, it is not saved to the database - the updates to the products are not processed.

What appears to be occurring is that once a system record with no "poducts" tag is encountered in the XML, no further processing of products data occurs for systems after that one (though the details data does get processed.) The user receives the "submission successful" message for each subsequent system, but the reality is the product data is not being checked.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.