GSA / GSA/GSA-APIs

Standard Rate is always "false"

Open
#67 0 comments 2 reactions 0 assignees View on GitHub
per diem v2
Dominant language
No language data
Stars
11
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Using the per diem api https://open.gsa.gov/api/perdiem/, if the Standard Rate is included in the response, it is not flagged as `"standardRate": true`

It appears to be the case for all these APIs:
https://api.gsa.gov/travel/perdiem/v2/rates/city/{city}/state/{ST}/year/{year}
https://api.gsa.gov/travel/perdiem/v2/rates/state/{ST}/year/{year}
https://api.gsa.gov/travel/perdiem/v2/rates/zip/{zip}/year/{year}

Additionally the response varies between year, prior to 2019 the response was:
```
"county": "STANDARD RATE",
"city": "Standard Rate",
"standardRate": "false"
```
Since 2019:
```
"county": "",
"city": "Standard Rate",
"standardRate": "false"
```
Should I use `"city" == "Standard Rate"` as the test for the standard rate? Have I misunderstood the point of the `"standardRate"` property? Is the property deliberately a String type rather than boolean?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.