GIScience / GIScience/oshdb

Be consistent on Tag and Geometry retrieval for OSMContribution

Open
#508 3 comments 0 reactions 0 assignees View on GitHub
priority:low question
Dominant language
Java
Stars
131
Forks
19
PR merge metrics
No merged PRs in 30d

Description

### Problem Description

To extract `OSHDBTags` from an `OSMContribution` one needs to extract the `OSMEntity` first like `contribution.getEntityBefore().getTags()`.

The extraction of the `Geometry` from an `OSMContribution` is located directly with the `OSMContribution` e.g. `contribution.getGeometryUnclippedBefore()`.

This seems incoherent and makes client code less readable.

### Expected Solution

Move `Geometry`-retrieving methods from `OSMContribution` to `OSMEntity`.

### Alternative Solutions

Move `OSHDBTags` retrieving methods to `OSMContribution`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.