GIScience / GIScience/ors-map-client

Refactor map-view-data-builder.js

Open
#323 0 comments 0 reactions 0 assignees View on GitHub
high priority medium priority
Dominant language
JavaScript
Stars
145
Forks
39
PR merge metrics
No merged PRs in 30d

Description

there are currently 2 similar and confusing functions:
- `buildMapViewData`: 'Build and returns map data' (according to docs)
- `buildMapData`: 'Build the mapViewData object' (according to docs)

They should be named to what they actually do.
At first glance they seem to do circular calls due to calling another `.buildMapData` function, which should be handled
in this change as well

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.