GIScience / GIScience/openrouteservice-py

Distance_matrix not working with metrics parameter

Open
#89 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
455
Forks
68
PR merge metrics
No merged PRs in 30d

Description

#### Here's what I did

Used following code:
```
client_ors = openrouteservice.Client(key='')
df_bus_stops_distances = client_ors.distance_matrix(llist_coords_bus_stops, metrics="distance")
```
and same without metrics parameter.

Tried on the API-Playground, it worked. Tried with the example code as python snippet from the API-Playground, that also worked.

---
#### Here's what I got

```
url:
https://api.openrouteservice.org/v2/matrix/driving-car/json?
Headers:
{
"headers": {
"User-Agent": "ORSClientPython.v2.2.2",
"Content-type": "application/json",
"Authorization": ""
},
"timeout": 60,
"json": {
"locations": [
[
x,
y
],
[
x,
y
],
[
x,
y
],
[
x,
y
],
[
x,
y
],
[
x,
y
],
[
x,
y
],
[
x,
y
],
[
x,
y
],
[
x,
y
]
],
"profile": "driving-car",
"metrics": "distance"
}
}
```

`openrouteservice.exceptions.ApiError: 400 ({'error': {'code': 6003, 'message': "Parameter 'metrics' has incorrect value or format."}, 'info': {'engine': {'build_date': '2023-06-16T03:06:42Z', 'version': '7.1.0'}, 'timestamp': 1687986526446}})
`

---
#### Here's what I was expecting

Should get a working response, as using metrics-parameter works on normal REST-API calls (API-Playground/python example code)

---
#### Here's what I think could be improved

Looked at the code of this package, especially at the distance_matrix.py. Couldn't figure out the problem. I'm sorry.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in distance_matrix.py and compare the request generated by client_ors.distance_matrix(..., metrics="distance") with the working Python snippet from the API Playground. Reproduce the 400 response, then verify that the metrics request is accepted and returns a working response.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.