GIScience / GIScience/openrouteservice-examples

Few improvements to Logistics example

Open
#14 2 comments 0 reactions 1 assignee Claimed by @thegialeo View on GitHub
Dominant language
Jupyter Notebook
Stars
109
Forks
47
PR merge metrics
No merged PRs in 30d

Description

1. No need for HD polygon here actually. You're not using it except for plotting. Think you can leave it out.
2. The first locations list:
- Only give the addresses and demands as assumption and use `geocoding` (the Pelias endpoint pls) to get the coordinates
- change the order to `address, demand, long, lat`
3. I generally like the approach with `numpy` and `pandas`, but try to keep your variables named, i.e. try to avoid to do e.g. `route[:, ::-1].T`. It's best done in dictionaries, I find, where you can put named keys. It makes it a lot nicer and easier to read.
4. `reversed` for an iterator is preferrable over `[::-1]`. Both for performance and readability.

Apart from that, very well done. I know, it can be hard, but try to think most practical with these examples, a fluid storytelling with just enough info to solve a certain problem in the most elegant and readable way.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.