GIScience / GIScience/openpoiservice

Osmium not able parse polygons with inner rings

Open
#98 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
199
Forks
25
PR merge metrics
No merged PRs in 30d

Description

See here https://github.com/osmcode/libosmium/issues/225.

Whilst importing osm files osmium will raise a RuntimeError when a polygon has inner rings.

How to solve: before parsing to wkbFactory.create_multipolygon(o) make sure that only the outer ring of the polygon is used.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the import path that calls wkbFactory.create_multipolygon(o), and review the related libosmium issue linked in the report. Confirm how polygons with inner rings are passed to that call; done means importing such a polygon no longer raises RuntimeError and uses only its outer ring.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.