GIScience / GIScience/Leaflet.Heightgraph
Why are xTicks and yTicks set using Math.pow
- Dominant language
- JavaScript
- Stars
- 101
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Description
I was wondering if there was a specific reason to change the x- and yTick implementation to use the power of 2? This makes it a) more complicated for to understand how it works, b) makes setting any tick values that are no multiples of 2 more complicated and c) seems like an unnecessary breaking change.
For users of d3 this is also a bit counter-intuitive. If you are used to the exiting x- and yTick arguments of d3, using exponentially growing ticks is probably a bit irritating.
I used to set the tick values to 5. With the new ticks, the almost equivalent value would be 2.33, but I had to look at the implementation to understand what is happening.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.