Floating divide by zero in subroutine SettlingSolver
Open
Nobody has claimed this yet.
bug
- Dominant language
- Fortran
- Stars
- 29
- Forks
- 22
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 4
Description
Code crashes with floating divide by zero error at
This is because nSubSteps becomes zero. This seems to be because sometime the array tau has negative values.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Process_Library/GOCART2G_Process.F90 around line 1580 and inspect the SettlingSolver subroutine, especially how tau values determine nSubSteps. Reproduce the floating divide-by-zero failure and trace where negative tau values originate. Done means the settling calculation no longer crashes when this input occurs, with relevant behavior covered by a regression test if the repository provides a suitable test location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100