[NDSL] Moist final saturation codes

Open
#943 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
fortran
Domain
hpc

Research direction

Start with GEOS_Shared/GEOS_Utilities.F90, especially the implementations of GEOS_QsatICE, GEOS_DQSAT, and GEOS_QsatLQU, then inspect the pyMoist entry points. Done means porting QSATICEX, QSATLQU, and DQSAT to pyMoist, keeping the shared code separate from the normal Moist code, and documenting it heavily.

Written by the indexing model from the issue text.

Description

At the end of the Moist numerics a series of Saturation related code are executed:

  • GEOS_QsatICE
  • GEOS_DQSAT
  • GEOS_QsatLQU

Original code is in file @GMAO_Shared/GEOS_Shared/GEOS_Utilities.F90

This should be saved aside of the normal Moist code since it's a shared code. Document heavily.

Parent: https://github.com/GEOS-ESM/SMT-Nebulae/issues/57

  • Port QSATICEX to pyMoist
  • Port QSATLQU to pyMoist
  • Port DQSAT to pyMoist
Dominant language
Fortran
Stars
10
Forks
13
Avg merge
17h 35m
Merged PRs (30d)
14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from GEOS-ESM/GEOSgcm_GridComp

All issues in GEOS-ESM/GEOSgcm_GridComp

Similar issues

More HPC issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.