GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp

Incorrect valid range in WSUB_ExtData.yaml

Open
#849 2 comments 0 reactions 1 assignee View on GitHub

@dbarahon is already working on this.

Since Oct 26, 2023.

bug
Dominant language
Fortran
Stars
10
Forks
13
Avg merge
17h 35m
Merged PRs (30d)
14

Description

A user trying to run the 2 moment micro physics at NAS was having some troubles in ExtData. Turns out the issue was that the "valid range" in this file is wrong for the dataset (note user is using the same data but obviously had to change the path since this is hard coded for discover still):
https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/develop/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/WSUB_ExtData.yaml

To quote what is there now:

Collections:
  WSUB_SWclim_2005%m2.nc4:
    template: /discover/nobackup/dbarahon/DEV/SWclim/L72/SWclim_2005%m2.nc4
    valid_range: "2005-01-01/2005-12-31"

That valid range is wrong, the dataset is only valid through 2005-12-01 so it should be changed to this:

Collections:
  WSUB_SWclim_2005%m2.nc4:
    template: /discover/nobackup/dbarahon/DEV/SWclim/L72/SWclim_2005%m2.nc4
    valid_range: "2005-01-01/2005-12-01"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.