GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp

aer_actv_single_moment.F90 function Aer_Activation needs return code

Open
#848 0 comments 0 reactions 2 assignees View on GitHub

@dbarahon is already working on this.

Since Oct 25, 2023.

bug
Dominant language
Fortran
Stars
10
Forks
13
Avg merge
17h 35m
Merged PRs (30d)
14

Description

I was trying to chase an issue in moist and found that the routine Are_Activation in aer_actv_single_moment.F90

does not have a return code option despite fact that there are dozens of calls that use the RC and STAT macros. Since there is no return code these do nothing. This really should have a return code, the code will just keep running if there's an error here...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.