handleInc_ procedure is not being trapped on error
@sdrabenh is already working on this.
Since Aug 30, 2023.
Assessment
This issue has not been assessed yet.
Description
While chasing a replay issue for a user, I was running an ERA5 replay and forgot to add
REPLAY_O3: NO
as did the user. The ERA5 files do not have an O3 analysis. This causes the handleInc_ procedure to throw an error.
The particular code is this:
if( .not.FOUND .and. L_REPLAY_O3 ) then
write(STRING,'(A)') "ANA Variable: O3 Not Found!"
call WRITE_PARALLEL( trim(STRING) )
RETURN_(ESMF_FAILURE)
endif
but if one looks when handleInc_ is called the return code is not checked, making any sort of error handling like this pointless. The error code should be check so the code dies if the user is trying to replay a variable that does not exist in the file. By returning early from handleInc_ clearly a lot of code in handleInc_ is skipped but we run along.
- Dominant language
- Fortran
- Stars
- 10
- Forks
- 13
- Avg merge
- 17h 35m
- Merged PRs (30d)
- 14
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from GEOS-ESM/GEOSgcm_GridComp
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
GEOS-ESM/GEOSgcm_GridComp#1410 ·
-
MAPL3
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
GEOS-ESM/GEOSgcm_GridComp#1403 ·
-
MAPL3
Difficulty 1/5 Under an hour Newbie friendliness 88/100
GEOS-ESM/GEOSgcm_GridComp#1401 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
GEOS-ESM/GEOSgcm_GridComp#1361 ·
-
acg-migration mapl3-readiness
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
GEOS-ESM/GEOSgcm_GridComp#1292 ·