GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp
Fix science issues in make_bcs (GEOSsurface_GridComp/Utils/Raster/)
Open
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 10
- Forks
- 13
- Avg merge
- 17h 35m
- Merged PRs (30d)
- 14
Description
#763 identifed the following issues with the generation of the EASE grid tile space:
- The Pfafstetter (catchment) ID assigned to a tile is that of the last contributing raster grid cell and not that of the dominant catchment within the EASE grid cell. An analysis by @zyj8881357 showed that approximately 36% of EASEv2_M09 tiles and 80% of EASEv2_M36 tiles do not represent the dominant catchment.
- The min/max lat/lon values for each tile in the catchment.def file seem to be associated with the EASE grid cell and not the desired lat/lon boundaries of the tile.
- It remains unclear if the adjustment of the land tile elevation properly accounts for lake and landice surfaces. This requires further examination.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in GEOSsurface_GridComp/Utils/Raster/ and trace make_bcs's EASE grid tile generation, then inspect how catchment.def records Pfafstetter IDs and min/max lat/lon. Compare the generated values with dominant catchments and the desired tile boundaries, and examine whether lake and landice surfaces are handled in the elevation adjustment. Done means all three reported science issues have verified behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- data
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100