GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp

Convert MG to REAL32

Open
#570 4 comments 0 reactions 3 assignees View on GitHub

@darianboggs is already working on this.

Since Oct 12, 2022.

enhancement
Dominant language
Fortran
Stars
10
Forks
13
Avg merge
17h 35m
Merged PRs (30d)
14

Description

@wmputman has expressed a desire to run the MG code in REAL32. From my reading of what might be in Moist at the moment, it looks like it is ALL in REAL64.

The SI Team can help with this, but we'd need some help from @wmputman and @dbarahon

  1. What version of MG? 1, 2, 3? I'm not sure working on MG1 is worth the effort (I seem to remember @dbarahon saying it's essentially out of date), so should we focus only on MG3?
  2. What is the current "correct" MG code? The code in develop? The code in #436 from @dbarahon ? Or perhaps one of the codes in one of the branches by @wmputman (there seem to be around 60 of those at the moment).
  3. Our team could probably "blindly" update the code to REAL32, but that might not be correct science-wise. @dbarahon Can you advise/help us when we know what code to look at which routines might need to stay REAL64 for scientific reasons?

cc: @tclune

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.