GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp

PEATCLSM outstanding issues

Open
#539 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Fortran
Stars
10
Forks
13
Avg merge
17h 35m
Merged PRs (30d)
14

Description

Summary of things not yet addressed in PR #524:

  • 1. Document revised water balance equation: WCHANGE = PR - EVAP – RUNOFF - FSWCHANGE
  • 2. Revisit re-gridding (re-tiling) of restarts for peat tiles ([..]/Utils/mk_restarts/Scale_Catch[CN].F90).
  • 3. Revisit hybridization of PEATMAP and HWSD in bcs generation. Is the peat area fraction [PMAP] ok for non-EASE tile spaces? Close enough for EASE tile spaces? Note pmap_thresh=0.5 in mod_process_hres_data.F90. Addressed with #1196.
  • 4. Revisit relationship between peat area fraction [PMAP] from PEATMAP/HWSD consistent with that used for fire (“peatf”) in CatchmentCNCLM45 input file (CLM4.5_abm_peatf_gdp_hdm_fc)
  • 5. Investigate snow water balance print statements in StieglitzSnow.F90 (~line 971), which were called out in a comment by Michel Bechtold in an early version of PEATCLSM. [Done, no action needed, 20 Feb 2022]
  • 6. Resolve inconsistency in soil parameter for some peat tiles (attempted but not completed in #576). Addressed with #1196.

cc: @biljanaorescanin

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the unchecked items from PR #524, especially Scale_Catch[CN].F90, mod_process_hres_data.F90, and the PEATMAP/HWSD and CatchmentCNCLM45 relationships. Confirm which investigations remain relevant before changing anything. Done means each outstanding item is resolved or documented and the checklist is updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.