GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp
Crash in fv_computeMassFluxes_r8 due to uninitialized halo values
Open
Beginner friendly
Nobody has claimed this yet.
bug
- Dominant language
- Fortran
- Stars
- 10
- Forks
- 13
- Avg merge
- 17h 35m
- Merged PRs (30d)
- 14
Description
fv_computeMassFluxes_r8 calls compute_utvt with uc and vc that have uninitialized halos which causes the code to crash. The solution is to set them to 0 before assigning the non-halo part, and the r4 version of this subroutine already does that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the r8 and r4 versions of fv_computeMassFluxes_r8 and compare how they initialize uc and vc before assigning the non-halo values. Confirm the r8 halos are initialized consistently with the r4 version, then verify that compute_utvt no longer receives uninitialized halo values and the crash is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100