GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp
DT Flexibility
Open
@weiyuan-jiang is already working on this.
Since Jan 28, 2022.
enhancement
- Dominant language
- Fortran
- Stars
- 10
- Forks
- 13
- Avg merge
- 17h 35m
- Merged PRs (30d)
- 14
Description
There is a need to make the clock heartbeat smaller to match the remapping sub-step in FV. Since we cannot afford to run every single gridded component at such smaller time step, we need to design a scheme to run at least some gridded components less frequently. As @wmputman suggested, we will start with Moist.
As @tclune suggested yesterday, here is a list tasks to accomplish this:
- Check that Moist never gets its DT from the CLOCK. I am nearly 100% sure that the current code is Ok, and Moist gets its DT from the resource RUN_DT. Still this should be double-checked
- Make sure we export tendencies and not increments (again, I am almost sure this is the case)
- Create a new alarm in Moist during Initialize. MAPL already creates its own RUN_DT alarm. but that alarm rings at the last step of the RUN_DT interval. The new alarm should ring at the first step of the interval, so that Moist could populate its exports properly.
- Add logic in the run method to skip the calculations if the alarm is not ringing. All the exports and internal state variables will automatically persist when the component skips the run step. Execute the actual Run method only when the alarm is ringing
- Double-check the logic that updates in-place some variable (sync T and Q logic)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.