GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp
MAPL_VarReads in landsurface regridding codes lack error checking!
@gmao-jkolassa is already working on this.
Since Oct 6, 2021.
- Dominant language
- Fortran
- Stars
- 10
- Forks
- 13
- Avg merge
- 17h 35m
- Merged PRs (30d)
- 14
Description
We were trying to debug an issue with regrid.pl, that it was giving different answers relative to some previous release. Close inspection the log revealed a bunch of error messages that the start+count during a netcdf read was exceeded but because the rc status of MAPL_VarRead is not checked in mk_CatchRestart.x code this just slipped through and produced a restart (albeit with 0 values for some variables).
If it had been being checked the code should have died and regrid.pl would have failed alerting us to a problem.
So mk_CatchRestart.x and any other code in the surface regridding directory that uses MAPL_VardRead or any other subroutine or function that has an rc code needs to be checked!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.